#81 Music Player ready to join

Закрито
Farmerjoe12 хоче злити 0 комітів з deleted до dev
Farmerjoe12 прокоментував(ла) 5 роки тому

The music player component should be ready to merge with the main branch.

The music player component should be ready to merge with the main branch.
shuvit прокоментував(ла) 5 роки тому
Власник

There was some weirdness on startup I need to look into more, also it throws a bunch of errors on startup before the controller gets connected/setup, it’d be nice to catch those, or just delay the player’s startup.

This happened 4 or 5 songs in, which is a weird place for it to happen:

  File "D:\x\MusicPlayer.py", line 91, in update
    self.nextSong()
  File "D:\x\MusicPlayer.py", line 127, in nextSong
    self.playlist.remove(self.currentNode)
  File "D:\x\DList.py", line 63, in remove
    current_node.next.prev = current_node.prev
AttributeError: 'NoneType' object has no attribute

There was some weirdness on startup I need to look into more, also it throws a bunch of errors on startup before the controller gets connected/setup, it'd be nice to catch those, or just delay the player's startup. This happened 4 or 5 songs in, which is a weird place for it to happen: ``` File "D:\x\MusicPlayer.py", line 91, in update self.nextSong() File "D:\x\MusicPlayer.py", line 127, in nextSong self.playlist.remove(self.currentNode) File "D:\x\DList.py", line 63, in remove current_node.next.prev = current_node.prev AttributeError: 'NoneType' object has no attribute ```
shuvit прокоментував(ла) 5 роки тому
Власник

Haven’t been able to reproduce the empty current node so far.

It doesn’t seem to startup like it should? Maybe there was some miscommunication on my part, sorry. If dict[‘music_player’] == 1 the game is supposed to start with the music playing. If it’s 0 it’s supposed to start off. Your player is always starting in the off state.

Haven't been able to reproduce the empty current node so far. It doesn't seem to startup like it should? Maybe there was some miscommunication on my part, sorry. If dict['music_player'] == 1 the game is supposed to start with the music playing. If it's 0 it's supposed to start off. Your player is always starting in the off state.
Farmerjoe12 прокоментував(ла) 5 роки тому
Співавтор

Looks like we’ve got an issue.. I guess when I tried to update all the local files on my machine from blender it changed all the scripts. So the two I uploaded weren’t ready in that form, and I don’t have the updates that made them work. So I’ll have to fix them.

Looks like we've got an issue.. I guess when I tried to update all the local files on my machine from blender it changed all the scripts. So the two I uploaded weren't ready in that form, and I don't have the updates that made them work. So I'll have to fix them.
Будь ласка перевідкрийте цей запит щоб здіснити операцію злиття.
Підпишіться щоб приєднатися до обговорення.
Етап відсутній
Немає виконавеця
2 учасників
Дата завершення

Термін виконання не встановлений.

Залежності

Цей запит на злиття в даний час не має залежностей.

Завантаження…
Відмінити
Зберегти
Тут ще немає жодного змісту.