#81 Music Player ready to join

Закрыто
Farmerjoe12 хочет смерджить 0 коммит(ов) из deleted в dev
Farmerjoe12 прокомментировал 5 лет назад

The music player component should be ready to merge with the main branch.

The music player component should be ready to merge with the main branch.
shuvit прокомментировал 5 лет назад
Владелец

There was some weirdness on startup I need to look into more, also it throws a bunch of errors on startup before the controller gets connected/setup, it’d be nice to catch those, or just delay the player’s startup.

This happened 4 or 5 songs in, which is a weird place for it to happen:

  File "D:\x\MusicPlayer.py", line 91, in update
    self.nextSong()
  File "D:\x\MusicPlayer.py", line 127, in nextSong
    self.playlist.remove(self.currentNode)
  File "D:\x\DList.py", line 63, in remove
    current_node.next.prev = current_node.prev
AttributeError: 'NoneType' object has no attribute

There was some weirdness on startup I need to look into more, also it throws a bunch of errors on startup before the controller gets connected/setup, it'd be nice to catch those, or just delay the player's startup. This happened 4 or 5 songs in, which is a weird place for it to happen: ``` File "D:\x\MusicPlayer.py", line 91, in update self.nextSong() File "D:\x\MusicPlayer.py", line 127, in nextSong self.playlist.remove(self.currentNode) File "D:\x\DList.py", line 63, in remove current_node.next.prev = current_node.prev AttributeError: 'NoneType' object has no attribute ```
shuvit прокомментировал 5 лет назад
Владелец

Haven’t been able to reproduce the empty current node so far.

It doesn’t seem to startup like it should? Maybe there was some miscommunication on my part, sorry. If dict[‘music_player’] == 1 the game is supposed to start with the music playing. If it’s 0 it’s supposed to start off. Your player is always starting in the off state.

Haven't been able to reproduce the empty current node so far. It doesn't seem to startup like it should? Maybe there was some miscommunication on my part, sorry. If dict['music_player'] == 1 the game is supposed to start with the music playing. If it's 0 it's supposed to start off. Your player is always starting in the off state.
Farmerjoe12 прокомментировал 5 лет назад
Соавтор

Looks like we’ve got an issue.. I guess when I tried to update all the local files on my machine from blender it changed all the scripts. So the two I uploaded weren’t ready in that form, and I don’t have the updates that made them work. So I’ll have to fix them.

Looks like we've got an issue.. I guess when I tried to update all the local files on my machine from blender it changed all the scripts. So the two I uploaded weren't ready in that form, and I don't have the updates that made them work. So I'll have to fix them.
Пожалуйста, переоткройте этот Pull Request для выполнения слияния.
Войдите, чтобы присоединиться к обсуждению.
Нет этапа
Нет назначенных лиц
2 участников
Срок выполнения

Срок выполнения не установлен.

Зависимости

Этот запрос на слияние в настоящее время не имеет никаких зависимостей.

Загрузка…
Отмена
Сохранить
Пока нет содержимого.